Don't append "m" ABI flag in Python 3.8 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 59.64% 59.64%
=======================================
Files 12 12
Lines 840 840
=======================================
Hits 501 501
Misses 339 339
Continue to review full report at Codecov.
|
auvipy
approved these changes
Aug 14, 2019
rdb
changed the title
|
Thanks! |
|
@agronholm Thanks for merging! It would be nice if we could see this make it into a release sometime before the release candidate so that wheel builders could already start building Windows wheels for Python 3.8. |
|
I plan to cut a patch release after one or two minor fixes that I have left. |
|
I've now put out the v0.33.5 patch release. |
|
Thank you! |
|
FWIW, wheels can no longer be installed on Windows using:
|
|
@cgohlke Correct, because pip has a similar bug. This will be fixed in pip 19.2.3, which will be released shortly. See pypa/pip#6885 |
This was referenced Oct 4, 2019
remeh
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 18, 2019
We've a bug while building python3 due to this: - pypa/wheel#303 We need pip3 >= `19.2.3`.
remeh
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Feb 3, 2020
* Upgrade to Python 3.8 * Update Python 3.8 hash (Linux). * Update python3 shasum for windows. * Patch must be applied to Python 3.8 now. * Update sha256 to reflect new zips * omnibus: update pip3. We've a bug while building python3 due to this: - pypa/wheel#303 We need pip3 >= `19.2.3`. * omnibus: in order to use a more recent pip, we need a more recent pip-tools. pip >= 19.3 support landed in pip-tools 4.2.0 * Release note entry. * Apply suggestions from code review Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update releasenotes/notes/python-3-8-c66cde69f972eb1e.yaml Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * tasks: use `distro` instead of `platform` to get running linux distribution. * gitlab-ci: install requirements deps for invoke tasks. * Revert "gitlab-ci: install requirements deps for invoke tasks." This reverts commit 9a6b8c7. * gitlab-ci: use new builders shipping `distro` dep for invoke tasks. * gitlab-ci: ebpf tests also need the distro dep * gitlab-ci: builders images. * general: update python 3 to 3.8.1 * gitlab-ci: install `distro` dep for python 3 in tests ebpf job. * gitlab-ci: merge WINBUILDIMAGES and BUILDERS vars. * omnibus: python3.8.1 checksum. * gitlab-ci: merge ARMBUILDIMAGES and BUILDIMAGES env vars. * omnibus/python3: update sha256sum of windows archives. * empty commit, can't find my pipeline * tasks: python 3.8 compliant. See https://docs.python.org/3/whatsnew/3.8.html#porting-to-python-3-8 * omnibus/python3: update wheel dep to 0.34.1 * appveyor: configure appveyor to use python 3.8 * python3: updated python 3.8.1 32bits for windows sha256sum * omnibus/pkg-scripts: remove downloader data for both 3.7 & 3.8 pythons * omnibus: remove pythons download data at the right moment only. * omnibus: properly call remove_downlaoder_data for centos. * gitlab: use new builders images. * gitlab: use builders images merged in master. * gitlab-ci: use the requirements.txt while installing distro for the ebpf part * tasks/build_tags: proper entry for redhat since we switched to distro.id() * packages-scripts: also remove python 3.8 in preinst * Revert "omnibus: properly call remove_downlaoder_data for centos." This reverts commit 427eba3. * releasesnotes: update python 3.8.1 release note entry. * Update releasenotes/notes/python-3-8-c66cde69f972eb1e.yaml Co-Authored-By: Olivier Vielpeau <olivielpeau@users.noreply.github.com> * releasenotes: adapt python 3.8.1 release note entry. * releasenotes: remove mention of a7 py version. Co-authored-by: Derek Brown <derek.brown@datadoghq.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: Olivier Vielpeau <olivielpeau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.8, the
mflag is no longer appended to the SOABI, since the ABI is longer influenced by enabling pymalloc. This PR should fix the ability to install Python 3.8 wheels on Windows. In Python 3.8,sys.abiflagsis an empty string.https://docs.python.org/dev/whatsnew/3.8.html#build-and-c-api-changes
https://bugs.python.org/issue36707
See also pypa/pip#6874