remove 'm' from python path for 3.8 and up #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manylinux_utils.sh
Outdated
| @@ -21,6 +21,7 @@ function cpython_path { | |||
| local py_ver="${1:-2.7}" | |||
| local u_width="${2:-${UNICODE_WIDTH}}" | |||
| local u_suff=u | |||
| local m=m | |||
There was a problem hiding this comment.
m is a little too short. OK to change to abi_suff? Maybe move line above local u_suff=u to reflect ordering in output string?
manylinux_utils.sh
Outdated
| @@ -31,8 +32,12 @@ function cpython_path { | |||
| echo "Incorrect u_width value $u_width" | |||
| exit 1 | |||
| fi | |||
| # Python 3.8 and up no longer uses the PYMALLOC 'm' suffix | |||
There was a problem hiding this comment.
Add comment reference to pypa/wheel#303 ?
|
added 3.8 travis runs, I think they should specify manylinux2010 for now until pypa/manylinux#360 goes in |
|
OK - thanks - seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to gh-261
CPython no longer adds 'm' to the abi tag after pypa/wheel#303 for python 3.8 and up