This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
Minor fixes #404
Open
Minor fixes #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trema96
commented
Jun 13, 2022
•
trema96
commented
- Fix InternalDAO get with rev
- Make purge(Collection) reactive?
|
|
lisatr2812
suggested changes
Jun 19, 2022
There was a problem hiding this comment.
Before refactoring the GenericDAO, I would like to be sure we are not breaking anything, as this is one of the most used components in BackEnd.
Could you add a unit test to ensure the behaviour of purge method is still the same and do some test in acceptance environment ?
| @@ -291,17 +290,16 @@ abstract class GenericDAOImpl<T : StoredDocument>( | |||
| } | |||
| } | |||
|
|
|||
| // This function is not reactive, but it doesn't seem to be used at all anyway... | |||
| override suspend fun purge(entities: Collection<T>) { | |||
| override suspend fun purge(entities: Collection<T>): Flow<DocIdentifier> = flow { | |||
There was a problem hiding this comment.
If this method returns a Flow, it should not be a suspend function anymore.
| afterDelete(entity) | ||
| } | ||
| val entitiesById = entities.associateBy { it.id } | ||
| val bulkDeleteResults = client.bulkDelete(entities.map { beforeDelete(it) }) |
There was a problem hiding this comment.
You can do it as a one-line code, this way :
emitAll(client.bulkDelete(entities.map { beforeDelete(it) })
.onEach { r -> entitiesById[r.id]?.let { afterDelete(it) } }
.map { updateResult -> DocIdentifier(updateResult.id, updateResult.rev) })
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.