Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding bug of short int #25

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Conversation

ikawaha
Copy link
Contributor

@ikawaha ikawaha commented Mar 19, 2018

This bug caused excessive evaluation of negative word_cost. (e.g. 研究=-413 is overvalued 65123.)
See #23

@codecov-io
Copy link

Codecov Report

Merging #25 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   93.82%   93.84%   +0.02%     
==========================================
  Files          22       22              
  Lines         923      926       +3     
  Branches      106      107       +1     
==========================================
+ Hits          866      869       +3     
  Misses         57       57
Impacted Files Coverage Δ
src/util/ByteBuffer.js 94.7% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f30e7e...4f5649c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.77% when pulling 4f5649c on ikawaha:fix/decode_short into 8f30e7e on takuyaa:master.

Copy link
Owner

@takuyaa takuyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -25,6 +25,14 @@ describe("ByteBuffer static methods", function () {
byteBuffer = new ByteBuffer(50);
});

it("putShort() and getShort()", function () {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@takuyaa takuyaa merged commit 0acbb7b into takuyaa:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants