Updates actions #141
Merged
Updates actions #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-gi
force-pushed
the
update-actions
branch
18 times, most recently
from
5fb53a7 to
8b726c4
Compare
mariocynicys
requested changes
Nov 4, 2022
.github/workflows/cln-plugin.yaml
Outdated
| if: ${{ steps.cache-cln.outputs.cache-hit != 'true' }} | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install gettext | ||
| sudo apt-get update && sudo apt-get install gettext |
There was a problem hiding this comment.
This line has an extra space at the end.
|
@mariocynicys should be OK now |
mariocynicys
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GH seems to have changed the way caches are handled and the old action caches are gone. Our CLN cache does not build anymore with the old actions (things used to work due to the old cache being restored).
Some actions are using deprecated stuff, update them. The only missing thing to be updated is actions-rs/toolchail, but there is no new version of it.
This is already been tracked, but looks like the project is not maintained:
actions-rs/toolchain#219
actions-rs/toolchain#221
If this ends up being an issue, we can manually install rust: actions-rs/toolchain#216 (comment)