Replaces sleep based waiting for log entry lookups #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@booklearner you may be interested in this (b/c of #90) |
|
I wanted to also address #156 here but I'm still unable to make it work consistently :( |
sr-gi
force-pushed
the
e2e-test-no-sleep
branch
from
b18696b to
484cde3
Compare
|
I was curious to see where |
sr-gi
added
tests
mariocynicys
reviewed
Dec 9, 2022
sr-gi
force-pushed
the
e2e-test-no-sleep
branch
2 times, most recently
from
a80d25f to
fddd477
Compare
|
I've improved the regexs to look for to be a bit less broad in fddd477 |
Replaces time.sleep in the `watchtower-plugin` tests to wait for certain things to happen on the backend by wait_for_logs, which should be less error prone Also does some reformating and removes unnecessary imports
sr-gi
force-pushed
the
e2e-test-no-sleep
branch
from
fddd477 to
5177446
Compare
`TeosD` outputDir was being set to the same directory use by the test suite. That cause it to be logging in the same log file, potentially colluding for read/write operations. Setting the outputDir to it's own location fixed the issue.
|
I ended up managing to fix #156! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
time.sleepin thewatchtower-plugintests to wait for certain things to happen on the backend bywait_for_logs, which should be less error-prone.Also does some reformating and removes unnecessary imports.
Fixes #163 #156 #90