Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of distfun_row and hclustfun_row #254

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

manor
Copy link
Contributor

@manor manor commented Oct 6, 2020

distfun_row and hclustfun_row are used instead of their column counterparts...

distfun_row and hclustfun_row are used instead of their column counterparts...
@talgalili
Copy link
Owner

talgalili commented Oct 6, 2020 via email

@codecov-commenter
Copy link

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files           9        9           
  Lines        1295     1295           
=======================================
  Hits         1158     1158           
  Misses        137      137           
Impacted Files Coverage Δ
R/heatmapr.R 80.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9bcf8...6ff305c. Read the comment docs.

@talgalili talgalili merged commit d4bf770 into talgalili:master Oct 9, 2020
@talgalili
Copy link
Owner

Merged, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants