Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #4041 to hyperv-iso builder #10

Closed
wants to merge 110 commits into from

Conversation

PatrickLang
Copy link

taliesins and others added 30 commits November 23, 2016 06:49
Remove steps that are windows specific
Move builder into correctly named folder
Use the convention for default hdd size
Tests added for builder
…s how other system like VeeWee do it.

Add support for number of cpus to use for vm
Add support for vm generation
Attempt to stop vm, before deleting it
Setup local http server
Add compaction of hard drive
GetHostAdapterIpAddress function added for hyperv
renamed step step_start_vm to step_run to fall in ine with naming conventions of other builders
…reate a dvd drive for os if it does not exist.

Allow secure boot mode to be configured from config.
Get VName out of state. This allows template replacement to be run on vmname
Don't want to be prompted for confirmation from powershell commandlets
Default minimum and maximum sizes were geared towards spinning up windows server instances. Linux instances are far more efficient and make do with lower requirements. Set the minimum sizes to match this.
…n array. Otherwise powershell may treat it as a property.

Stop-Vm with force parameter to ensure that powershell prompts will not appear
taliesins and others added 21 commits November 23, 2016 06:50
Fix code type for formatting
Remove empty space
Remove configuration elements that are no longer used.
…Server 2016 no longer come with iso. So default to not loading guest additions when the iso is missing
…uy Microsoft have changed the licensing to MPL2 and removed the copyright headers so that we can include it in the official Packer release.

microsoft/packer-hyperv@1ce6ba9?diff=unified#diff-5d60887f0940c9f8d6724e59843ac1fb
@taliesins
Copy link
Owner

I guess for now there is not a stable way to get the correct exit code from multiple operating systems.

This was the reason I hacked in the exit code == 1 && len(errout) < 1.

I am gonna give one final go tonight before I push merge button tommorow.

@taliesins
Copy link
Owner

@PatrickLang fix the conflict and I will merge it in

@PatrickLang
Copy link
Author

PatrickLang commented Dec 13, 2016

Ack, I'll do a rebase. be right back

Actually, it looks like the right change is on top. Is a squash or rebase actually needed?

@PatrickLang
Copy link
Author

Submitted alternate #11 that has no conflicts, clean history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants