Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the string concat method. Edit some error messages for clarity #18

Closed
wants to merge 1 commit into from

Conversation

weflower
Copy link

@weflower weflower commented Dec 31, 2017

I updated the way strings are concatenated/constructed to use the new .format() method (or just "+" when it's simple enough). The %s method that was used is deprecated in newer releases of Python, so future proofing in case Plex upgrades at some point.

I also edited some error messages for global English and clarity.

Update the method for string concatenation to new method (%s is deprecated).

Also edit error messages for global English and clarity.
@taligentx taligentx changed the base branch from master to develop July 8, 2018 20:04
taligentx added a commit that referenced this pull request Jul 8, 2018
@taligentx
Copy link
Owner

@weflower Thanks for the PR! I'm reviewing the code to see what changes are necessary with the current versions of the Plex server and clients. This PR required a manual merge for the develop branch, for now it's just the string substitution changes and will be looking at the error message wording changes.

@taligentx taligentx closed this Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants