Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow gcloud/publish to expose setup_remote_docker version #133

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: Allow gcloud/publish to expose setup_remote_docker version #133

merged 1 commit into from
Jan 15, 2024

Conversation

cphoward
Copy link
Contributor

@cphoward cphoward commented Jan 14, 2024 •
edited
Loading

Summary

Expose version for docker-configure to gcloud/publish for
setup_remote_docker.

Custom Checklist Items

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@cphoward cphoward requested review from TheKevJames and a team as code owners January 14, 2024 01:02
@cphoward cphoward requested review from jonathan-johnston and aherrada-dialpad and removed request for a team January 14, 2024 01:02
@cphoward cphoward merged commit 2722e46 into master Jan 15, 2024
1 check passed
@cphoward cphoward deleted the cph/gcloud-publish-docker-version branch January 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanamari94 juanamari94 juanamari94 approved these changes

@jonathan-johnston jonathan-johnston jonathan-johnston approved these changes

@TheKevJames TheKevJames Awaiting requested review from TheKevJames TheKevJames is a code owner

@aherrada-dialpad aherrada-dialpad Awaiting requested review from aherrada-dialpad aherrada-dialpad is a code owner automatically assigned from talkiq/engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cphoward @juanamari94 @jonathan-johnston