Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcloud): delete deploy-cloud-run #141

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

TheKevJames
Copy link
Member

Summary

Proposing that we delete this job, as it is very opinionated and
virtually every CR app we've deployed after releasing this orb has
needed a custom command anyway.

Could also generalize this more, but at that point... well, it's
basically a single gcloud command, are we really gaining much by
orbifying it?

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

Proposing that we delete this job, as it is *very* opinionated and
virtually every CR app we've deployed after releasing this orb has
needed a custom command anyway.

Could also generalize this more, but at that point... well, it's
basically a single gcloud command, are we really gaining much by
orbifying it?
@TheKevJames TheKevJames requested a review from a team as a code owner March 5, 2024 16:39
@TheKevJames TheKevJames requested review from jonathan-johnston, eddiedialpad and aherrada-dialpad and removed request for a team March 5, 2024 16:39
Copy link
Contributor

@eddiedialpad eddiedialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved: agree w your arguments + we don't deploy cloud runs from enough different repos (it's like two: tooling and offline, right?) to factor this out anyway

@TheKevJames TheKevJames merged commit db5ade5 into master Mar 6, 2024
13 checks passed
@TheKevJames TheKevJames deleted the kjames/delete-deploy-cloud-run branch March 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants