Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(poetry): install export plugin #167

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(poetry): install export plugin #167

merged 1 commit into from
Nov 28, 2024

Conversation

TheKevJames
Copy link
Member

Summary

This plugin will soon no longer be installed by default, add it
explicitly where we need it.

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@TheKevJames
fix(poetry): install export plugin
c57186c 
This plugin will soon no longer be installed by default, add it
explicitly where we need it.
@TheKevJames TheKevJames requested review from cphoward and a team as code owners September 12, 2024 14:54
@TheKevJames TheKevJames requested review from santiagofdialpad and olidp and removed request for a team September 12, 2024 14:54
@TheKevJames TheKevJames requested review from a team and shaundialpad and removed request for a team November 27, 2024 16:22
@TheKevJames TheKevJames merged commit b09d7ff into master Nov 28, 2024
13 checks passed
@TheKevJames TheKevJames deleted the kjames/add-poetry-export-plugin branch November 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olidp olidp olidp approved these changes

@santiagofdialpad santiagofdialpad santiagofdialpad approved these changes

@cphoward cphoward Awaiting requested review from cphoward cphoward is a code owner

@shaundialpad shaundialpad Awaiting requested review from shaundialpad shaundialpad is a code owner automatically assigned from talkiq/engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheKevJames @santiagofdialpad @olidp