Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some sub-reddits easier to browse when images are used #178

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eyecreate
Copy link

Hey! Glad to see this nice little reddit app open-source. Pretty much all the reddit apps I've seen on the market have this issue where subreddits where images are used, but can have text included on the hover, this isn't shown as it is snipped out by the parser. I added the ability to read text normally only visible by hovering over images by copying it into the main body. I'll be happy to see this launched on reddit-is-fun golden platinum on my phone in the near future!

@eyecreate
Copy link
Author

Oops, forgot the join method. Will commit that in today.

@talklittle
Copy link
Owner

I'm sure many people will appreciate this change! Thanks!
I'll make a few comments inline regarding code style. I can make the changes myself next time I get a chance to work on the app; or you could make the changes. Just let me know.

@talklittle
Copy link
Owner

Sorry for the delay with merging this. Lately I have been thinking to implement inline images, like rage faces, so I'm trying to determine how to combine the two features if possible. Thanks

@eyecreate
Copy link
Author

That would make a great combo feature. One thing I will mention is not all subreddits use the same set of images for "rage faces", so it'd have to use that subreddit's resources for images. I've seen other Reddit apps try to implement rage faces/inline images, but make that mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants