Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 add continuous deployment for tallyfor/re frame firebase #7

Merged

Conversation

pdelfino
Copy link
Collaborator

Hopefully, this solves #6

@pdelfino pdelfino added the enhancement New feature or request label Jan 10, 2023
@pdelfino pdelfino requested a review from benzenwen January 10, 2023 17:29
@pdelfino pdelfino force-pushed the 6-add-continuous-deployment-for-tallyfor/re-frame-firebase branch 3 times, most recently from fceb22c to 9b9e561 Compare January 10, 2023 17:36
@pdelfino pdelfino force-pushed the 6-add-continuous-deployment-for-tallyfor/re-frame-firebase branch from 9b9e561 to e70bd2e Compare January 10, 2023 17:45
@pdelfino
Copy link
Collaborator Author

This is ready for final review. It works: https://github.com/tallyfor/re-frame-firebase/actions/runs/3885805008

@pdelfino pdelfino self-assigned this Jan 10, 2023
Copy link
Collaborator

@benzenwen benzenwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benzenwen benzenwen merged commit a716301 into master Jan 11, 2023
@benzenwen benzenwen deleted the 6-add-continuous-deployment-for-tallyfor/re-frame-firebase branch January 11, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: create Continuous Deployment for this tallyfor/re-frame-firebase
2 participants