Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confidence Map Generation #11

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Confidence Map Generation #11

merged 5 commits into from
Aug 10, 2023

Conversation

davidasamy
Copy link
Contributor

@davidasamy davidasamy commented Jul 27, 2023 •
edited
Loading

Addresses confidence map generation.

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #11 (a3bb725) into main (fdf3cdd) will increase coverage by 0.74%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head a3bb725 differs from pull request most recent head 0c0061b. Consider uploading reports for the commit 0c0061b to get more accurate results

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   98.23%   98.97%   +0.74%     
==========================================
  Files           7        8       +1     
  Lines         113      195      +82     
==========================================
+ Hits          111      193      +82     
  Misses          2        2
Files Changed Coverage Δ
sleap_nn/data/confidence_maps.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@talmo talmo changed the base branch from main to david/instance-cropping July 27, 2023 16:38
@davidasamy davidasamy marked this pull request as ready for review August 1, 2023 16:51
@davidasamy davidasamy mentioned this pull request Jul 27, 2023
Closed
@davidasamy davidasamy requested a review from talmo August 3, 2023 19:02
Base automatically changed from david/instance-cropping to main August 3, 2023 19:54
talmo
talmo requested changes Aug 3, 2023
View reviewed changes
sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
sleap_nn/data/instance_cropping.py Outdated Show resolved Hide resolved
tests/data/test_confmaps.py Outdated Show resolved Hide resolved
sleap_nn/data/confidence_maps.py Show resolved Hide resolved
@davidasamy davidasamy changed the base branch from main to vincent/augmentation August 3, 2023 21:10
@davidasamy davidasamy changed the base branch from vincent/augmentation to main August 3, 2023 21:10
@davidasamy davidasamy force-pushed the david/conf-maps branch 3 times, most recently from 120f947 to b944101 Compare August 3, 2023 23:08
@davidasamy davidasamy requested a review from talmo August 3, 2023 23:15
talmo
talmo requested changes Aug 4, 2023
View reviewed changes
sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
sleap_nn/data/confidence_maps.py Show resolved Hide resolved
davidasamy and others added 2 commits August 4, 2023 10:33
@davidasamy @talmo
Channel first order
5262a6f 
Co-authored-by: Talmo Pereira <talmo@salk.edu>
@davidasamy
Add test for replacing nans.
e8cb308
@davidasamy davidasamy requested a review from talmo August 4, 2023 19:09
talmo
talmo requested changes Aug 4, 2023
View reviewed changes
sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
tests/data/test_confmaps.py Outdated Show resolved Hide resolved
roomrys
roomrys approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@roomrys roomrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fix one comment

sleap_nn/data/confidence_maps.py Outdated Show resolved Hide resolved
@davidasamy @roomrys
Update sleap_nn/data/confidence_maps.py
0c0061b 
Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
@roomrys roomrys merged commit fa15056 into main Aug 10, 2023
@roomrys roomrys deleted the david/conf-maps branch August 10, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roomrys roomrys roomrys approved these changes

@talmo talmo talmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidasamy @talmo @roomrys