-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Normalization order in data pipelines #118
base: talmo/fix-skel-serialization
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## talmo/fix-skel-serialization #118 +/- ##
=============================================================
Coverage 97.51% 97.51%
=============================================================
Files 38 38
Lines 3777 3781 +4
=============================================================
+ Hits 3683 3687 +4
Misses 94 94 ☔ View full report in Codecov by Sentry. |
Currently, in
streaming_datasets.py
, we read the PIL images from.bin
files, convert them totorch.float32
tensors to pass the images to kornia augmentation transforms, and we normalize image (images are scaled to [0,1]) after augmentation is applied. Instead, in this PR, we normalize image before applying kornia augmentation to remove redundancy.