-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify keys #31
modify keys #31
Conversation
WalkthroughThe changes across the files indicate a refactoring in the data handling for instance cropping in a neural network pipeline. The key "instances" and "centroids" are being popped from the source data and replaced with "centroid" in the output, suggesting a shift to single-instance processing. Additional keys related to bounding boxes and images are removed, while a new key for "confidence_maps" is introduced, hinting at a change in the data structure and processing strategy. Changes
Poem
TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 19 19
Lines 949 949
=======================================
Hits 947 947
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (4)
- sleap_nn/data/instance_cropping.py (2 hunks)
- sleap_nn/data/pipelines.py (2 hunks)
- tests/data/test_instance_cropping.py (2 hunks)
- tests/data/test_pipelines.py (5 hunks)
Files skipped from review due to trivial changes (2)
- sleap_nn/data/pipelines.py
- tests/data/test_instance_cropping.py
Additional comments: 1
sleap_nn/data/instance_cropping.py (1)
- 97-97: The addition of the "centroid" key to the yielded example is consistent with the PR's objective. Verify that the new key is properly handled in all places where the modified data structure is used.
The addition of the "centroid" key to the yielded example has been verified and is properly integrated in the tests and data pipeline code. No further issues found.
Summary by CodeRabbit
New Features
Bug Fixes
Tests