-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LitData Refactor PR4: Integrate LitData with ModelTrainer class #93
LitData Refactor PR4: Integrate LitData with ModelTrainer class #93
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## divya/add-streamingdataset #93 +/- ##
==============================================================
- Coverage 97.82% 97.01% -0.82%
==============================================================
Files 37 37
Lines 3493 3515 +22
==============================================================
- Hits 3417 3410 -7
- Misses 76 105 +29 ☔ View full report in Codecov by Sentry. |
This reverts commit ba53bc2.
This is the fourth PR for #80. Here, we integrate litdata with training.model_trainer.ModelTrainer class. In _create_data_loaders(), ld.optimize(fn = get_chunks) is used to generate the
.bin
files. The.bin
dir path is passed to the litdata.StreamingDataset class. (the .bin files are deleted after training)