Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish-up last resumable training PR #1165

Closed
wants to merge 13 commits into from

Conversation

roomrys
Copy link
Collaborator

@roomrys roomrys commented Feb 3, 2023

Description

The PR gets #1150 ready to be merged into the stacked PRs.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (finishing touches)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

roomrys and others added 13 commits January 19, 2023 11:11
…ems (#1134)

* Create signal that updates plot instead of redrawing

* Remove debug code

* Non-functional self-review changes
Ensure variable initialized before calling it
* [io] export tracking results to NIX file

* [io] nix added to export filter only if available

* [nixio] refactor, add scores link data as mtag

* [nixio] speeding up export by chunked writing

* [nixio] rename point score to node score

* [nixio] fix missing dimension descriptor for node scores

* [export analysis] support multiple formats also for bulk export

* [nixio] export centroid, some documentation

* [nixio] fix double dot before filename suffix

* [nixio] fix bug when not all nodes were found

* [nixio] housekeeping

* [nix] add nix analyis output format to convert

* [nix] tiny fix, catch file write error and properly close file

* [inference] main takes optional args. Can be imported to run inference form scripts

* [convert] simplify if else structure and outfile handling for analysis export

* [nix] use pathlib instead of os

* [nix] catch if there are instances with a None frame_idx ...

not sure why this occurred. The nix adaptor cannot save instances
that are not related to a frame.

* [nix] move checks to top of write function

* [nix] use absolute imports

* [nix] use black to reformat

* [commands] revert qtpy import and apply code style

* [convert] use absolute imports, apply code style

* [commands]fix imports

* [inference/nix]fix linter complaint, adjust nix types for scores

* [nix] add test case for nix export format

* [nix] extended testing, some modifications of adaptor

* [skeleton] add __eq__ to Skeleton ...

make Node.name and Node.weight instance variables instead of class
variables

* [nix] add nixio to requirements, remove unused nix_available, ...

allow for non-unique entries in node, track and skeleton. Extend node
map to store the skeleton it is part of

* [nix] make the linter happy

* [Node] force definition of a name

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>

* [nix] use getattr for getting grayscale information

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>

* [nix] fixes according to review

* [convert] break out of loop upon finding the video

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>

* [commands.py] use pathilb instead of splitting filename

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>

* [dev requirements] remove linebreak at last line

* [skeleton] revert attribute creation back to original

* [nix] break lines in class documentation

* Ensure all file references are closed

* Make the linter happy

* Add tests for ExportAnalysis and (docs for) sleap-convert

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
…1133)

* Create VisibleBoundingBox class.

* Added instance scaling functionality in addition to bounding box scaling functionality.

* Update sleap/gui/widgets/video.py

Co-authored-by: Talmo Pereira <talmo@salk.edu>

* Update sleap/gui/widgets/video.py

Co-authored-by: Talmo Pereira <talmo@salk.edu>

* Update sleap/gui/widgets/video.py

Co-authored-by: Talmo Pereira <talmo@salk.edu>

* Update sleap/gui/widgets/video.py

Co-authored-by: Talmo Pereira <talmo@salk.edu>

* Update sleap/gui/widgets/video.py

Co-authored-by: Talmo Pereira <talmo@salk.edu>

* Added new testing for scaling operation and simplified VisibleBoundingBox class code.

* Added type hinting to the scaling padding and removed erroneous bounding rect initialization.

Co-authored-by: Talmo Pereira <talmo@salk.edu>
Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
* Add better error message for top down

* Add test for error message

* Raise different error, fix test
@roomrys roomrys changed the base branch from develop to adam/resumable-training-3 February 3, 2023 18:05
@roomrys roomrys closed this Feb 3, 2023
@roomrys roomrys deleted the liezl/resumable-training-3 branch February 3, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants