Fix cropping when rendering video #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #842 +/- ##
===========================================
+ Coverage 66.73% 66.85% +0.12%
===========================================
Files 129 129
Lines 21729 21742 +13
===========================================
+ Hits 14500 14535 +35
+ Misses 7229 7207 -22
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…l/render-video-crop
talmo
reviewed
Jul 19, 2022
roomrys
commented
Jul 19, 2022
sleap/io/visuals.py
Outdated
Comment on lines
142
to
148
| except Exception as e: | ||
| raise (e) | ||
| finally: | ||
| if writer_object is not None: | ||
| writer_object.close() | ||
| # send (-1, time) to signal done | ||
| progress_queue.put((-1, total_elapsed)) |
There was a problem hiding this comment.
We are still able to get stuck in the code somewhere even with this try except finally executing as expected. For example, I intentionally errored-out to this message but was not returned to the CLI:
(sleap_render-video-crop) λ python tests\liezl_test_script.py
Saving config: C:\Users\TalmoLab/.sleap/1.2.4/preferences.yaml
Writing video with 14100 frame images...
INFO:sleap.io.visuals:Chunks: 221, chunk size: 64
Done in 0.41996690000000036 s, fps = 33574.07452825446.
Exception in thread Thread-3:
Traceback (most recent call last):
File "C:\Users\TalmoLab\miniconda3\envs\sleap_render-video-crop\lib\threading.py", line 926, in _bootstrap_inner
self.run()
File "C:\Users\TalmoLab\miniconda3\envs\sleap_render-video-crop\lib\threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "d:\social-leap-estimates-animal-poses\pull-requests\sleap_render-video-crop\sleap\sleap\io\visuals.py", line 145, in writer
raise (e)
File "d:\social-leap-estimates-animal-poses\pull-requests\sleap_render-video-crop\sleap\sleap\io\visuals.py", line 126, in writer
h, w = data[0].shape[:2]
AttributeError: 'NoneType' object has no attribute 'shape'
Definitely getting stuck in the thread, now just need to figure out how to get unstuck.
There was a problem hiding this comment.
Opting to push the crop video fixes in this PR and handle the threading hang-up as a different issue.
…l/render-video-crop
…l/render-video-crop
…l/render-video-crop
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although we allowed users to attempt to export a cropped version of their video - and had most of the code set-up to do so - there were still a few bugs making the crop feature unusable.
This PR allows users to render a cropped video that attempts to track instances in the frame - sometimes if instances move too fast, the crop does not follow in time due to smoothing or the crop may be too tiny to fit the instances.
Types of changes
Does this address any currently open issues?
Render Video > Crop Size: Half results in cv2.error #672
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️