Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retracking of old predictions #975

Closed
wants to merge 5 commits into from
Closed

Conversation

getzze
Copy link
Contributor

@getzze getzze commented Sep 30, 2022

Software versions:
SLEAP: 1.2.8

Description

PR #898 allows to retrack predictions, but for using with the GUI, it would be nice to have the option to define a prediction file to retrack.
This PR adds options to the GUI for that. It also makes retrack work with the GUI, it's currently broken.

It could be done better if the option was added in the predict_on combo_list at the bottom of the inference window, but it was a bit too complicated to understand how this widget is populated...
This is work in progress.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #975 (24f58b2) into develop (4d1154e) will decrease coverage by 0.74%.
The diff coverage is 53.12%.

❗ Current head 24f58b2 differs from pull request most recent head c12129e. Consider uploading reports for the commit c12129e to get more accurate results

@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
- Coverage    67.55%   66.80%   -0.75%     
===========================================
  Files          130      127       -3     
  Lines        22248    21515     -733     
===========================================
- Hits         15030    14374     -656     
+ Misses        7218     7141      -77     
Impacted Files Coverage Δ
sleap/gui/learning/runners.py 32.50% <41.66%> (+0.40%) ⬆️
sleap/nn/tracking.py 74.57% <41.93%> (+2.17%) ⬆️
sleap/nn/inference.py 78.87% <76.19%> (-0.13%) ⬇️
sleap/io/dataset.py 83.26% <0.00%> (-0.24%) ⬇️
sleap/gui/commands.py 58.32% <0.00%> (-0.09%) ⬇️
sleap/instance.py
sleap/message.py
sleap/__init__.py
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys
Copy link
Collaborator

roomrys commented Nov 8, 2022

Hi @getzze,

I see your description says this PR is a "work in progress". Just checking-in to see if it is ready for review?

Thanks,
Liezl

@getzze
Copy link
Contributor Author

getzze commented Nov 15, 2022

Hi @roomrys,
So, it's working but I'm not very satisfied with it, but I don't know how to improve it. So it would be nice if I can get some feedback from you :)
Thanks!

@roomrys roomrys added the stale but not fixed Issues that have been backlogged for a long time, but may be addressed in the future label Jan 19, 2023
@getzze
Copy link
Contributor Author

getzze commented Aug 2, 2024

closing because it is implemented in 1.3.3

@getzze getzze closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale but not fixed Issues that have been backlogged for a long time, but may be addressed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants