-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add demo_viz.p #45
add demo_viz.p #45
Conversation
WalkthroughWell, let me tell ya, there’ve been some changes made to that Jupyter notebook. They messed around with the video playback settings, slowing it down from 19.80 frames per second to 14.52. Also, the data file path got switched from "demo_fit.p" to "demos/demo_viz.p." Ain't much else changed, but these tweaks could affect how things run in that notebook. Changes
Sequence Diagram(s)(No diagrams generated as the changes do not warrant visual representation.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
demos/demo_viz.p
is excluded by!**/*.p
Files selected for processing (1)
- demos/viz_usage.ipynb (2 hunks)
Additional context used
Gitleaks
demos/viz_usage.ipynb
73-73: Identified a pattern that may indicate AWS credentials, risking unauthorized cloud resource access and data breaches on AWS platforms.
(aws-access-token)
Additional comments not posted (2)
demos/viz_usage.ipynb (2)
66-66
: Whoa there, slow down!The frame rate's been dropped from
19.80it/s
to14.52it/s
. Better make sure this don't mess up the video playback or processing speed.Double-check the impact of this frame rate change on the video rendering performance.
87-87
: Hold yer horses!The data path's been changed to
"demos/demo_viz.p"
. Make sure this here new path is correct and the data's where it oughta be.Double-check the new data path to ensure it's correct and the data is accessible.
@@ -63,14 +63,14 @@ | |||
" from pkg_resources import resource_filename\n", | |||
"0it [00:00, ?it/s]/Users/charleszhang/miniforge3/envs/stac-mjx/lib/python3.11/subprocess.py:1885: RuntimeWarning: os.fork() was called. os.fork() is incompatible with multithreaded code, and JAX is multithreaded, so this will likely lead to a deadlock.\n", | |||
" self.pid = _fork_exec(\n", | |||
"10it [00:00, 19.80it/s]\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to include these changes viz_usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran it to make sure it worked so the notebook completely updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently,
viz_usage.ipynb
relies ondemo_fit.p
which is an output fromapiusage.ipynb
. This PR addsdemo_viz.p
for the viz_usage notebook to use. It's the same data, but will live in the repo for the demo.Summary by CodeRabbit
New Features
Bug Fixes
Documentation