Allow passing arbitrary options to KaTeX #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be useful for things like the maxSize option.
ibrahima
commented
Jun 21, 2018
| @@ -40,7 +40,8 @@ const createMathComponent = (Component, { displayMode }) => { | |||
| return KaTeX.renderToString(props[this.usedProp], { | |||
| displayMode, | |||
| errorColor, | |||
| throwOnError: !!renderError | |||
| throwOnError: !!renderError, | |||
| ...this.props.katexOptions | |||
There was a problem hiding this comment.
Ah, this seems to break rollup, did I make a syntax error, or does your configuration not support the spread operator syntax?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Khan/KaTeX#rendering-options
Personally, I wanted to set the maxSize option to KaTeX, but I figured that there are a lot of other options to KaTeX that a user might want to pass in, and it would be tedious to try to keep this component in sync with any options that KaTeX adds. So I thought this would be a good approach.
We could also use PropTypes.shape and specify the currently known KaTeX options, and that way if any new options are added a user can still pass them in via an object, and the worst case is that they get a warning from PropTypes.
Let me know what you think. Thanks!