Fixes script race condition, updates react to latest and fixes travis tests #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice!!! Gonna merge it, it really seems to fix a lot of previous bugs. Thanks for your contribution 😄 |
talyssonoc
added a commit
that referenced
this pull request
Jan 20, 2016
Fixes script race condition, updates react to latest and fixes travis tests
| } | ||
| }, | ||
|
|
||
| handleEvents: function handleEvents() { | ||
| document.addEventListener('DOMContentLoaded', ReactLaravelUJS.mountComponents); | ||
| if (document.readyState == "complete" || document.readyState == "loaded" || document.readyState == "interactive") { |
There was a problem hiding this comment.
The line I was referencing in issue #68. Perhaps this may need to be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes everything! We can bundle the react js source files together if required, should make it more user friendly, although having just checked it seems like the react-php-v8js already creates a bundle file we can use. In any case that can be implemented later, this will just fix it for now.