Clean-up deps, fix vscode ext, refactor linter #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panekj
force-pushed
the
feat/split-linter
branch
from
3874e08
to
e238bd4
Compare
- make `lint` subcommand a feature-gated, enabled by default; only available to build, it will not be distributed by default, if it introduces a regression, it will be reverted; closes #694 - clean-up code a bit, make `lsp` subcommand fail properly as no subcommand found since the errors are swallowed somewhere before reaching stderr - remove references to `reqwest::Url`, use `url::Url` exclusively
panekj
force-pushed
the
feat/split-linter
branch
from
e238bd4
to
732e6da
Compare
panekj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make
lintsubcommand a feature-gated, enabledby default; only available to build, it will not
be distributed by default, if it introduces a
regression, it will be reverted; closes Option to install just formatter without any other features #694
remove
attydependency, useIsTerminalfromstdlib (available since rust 1.70)
clean-up code a bit, make
lspsubcommand failproperly as no subcommand found since the errors
are swallowed somewhere before reaching stderr
remove references to
reqwest::Url, useurl::Urlexclusively