Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Placeholder can have filters #3

Merged
merged 1 commit into from
Apr 28, 2015
Merged

Conversation

mikedobrin
Copy link
Contributor

Placeholder can have filters applied so it is better to treat it as an expression

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.11% when pulling 64fd78b on mikedobrin:master into ef65216 on tameraydin:master.

@mikedobrin
Copy link
Contributor Author

Dude, I can't understand why does it fail. You should be able to write something like:

inline-edit-placeholder='"PLACEHOLDER_TEXT" | translate',

Note: we dont wrap the value in {{ here, but do it inside the linking function of the directive

@tameraydin tameraydin merged commit 64fd78b into tameraydin:master Apr 28, 2015
@tameraydin
Copy link
Owner

2061c91 now this should work:
inline-edit-placeholder='{{"PLACEHOLDER_TEXT" | translate}}'
can you try?

@mikedobrin
Copy link
Contributor Author

Doesn't work.

I still get PLACEHOLDER_TEXT instead of the actual translation.

Check out this approach: http://plnkr.co/edit/8XMxgpq4A8VXMzDi87xn?p=preview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants