Skip to content

Commit

Permalink
Update patch set 2
Browse files Browse the repository at this point in the history
Patch Set 2:

> Patch Set 2:
> 
> expected, but only nova is good

I'm looking at this and have found that we're hitting this issue again:

harlowja/fasteners#36

due to this commit which was released in fasteners==0.15:

harlowja/fasteners@467ed75

Inside of the nova test fixture, we are somehow getting the unpatched version of threading.current_thread instead of the eventlet version that we need. This implies that at the time of the creation of our ReaderWriterLock inside the fixture, the threading module is not eventlet monkey patched:

harlowja/fasteners#36 (comment)

I don't know how or why this is the case, same as bnemec mentioned here:

harlowja/fasteners#36 (comment)

I'm going to keep looking but will need help from other nova devs who know more about eventlet.

Patch-set: 2
CC: Gerrit User 4690 <4690@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
  • Loading branch information
Gerrit User 4690 authored and openstack-gerrit committed Oct 6, 2021
1 parent 2021c96 commit 3e440c4
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 3e440c4

Please sign in to comment.