Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add set_timeout method on menu context #448

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

Aschubel
Copy link
Contributor

@Aschubel Aschubel commented Aug 28, 2024

Summary

Adding a set_timeout method on class components.MenuContext

Checklist

  • I have run nox and all the pipelines have passed.
  • I have created a changelog fragment to describe this change

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.70%. Comparing base (0092c29) to head (8490216).
Report is 1 commits behind head on master.

Files Patch % Lines
lightbulb/components/menus.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   50.70%   50.70%   -0.01%     
==========================================
  Files          34       34              
  Lines        2629     2631       +2     
==========================================
+ Hits         1333     1334       +1     
- Misses       1296     1297       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tandemdude tandemdude merged commit 5e48918 into tandemdude:master Aug 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants