Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 14 #34

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Support Node 14 #34

merged 2 commits into from
Dec 21, 2020

Conversation

vpillinger
Copy link
Contributor

@vpillinger vpillinger commented Dec 15, 2020

As far as I can tell, this package works in Node 14 but the package.json does not list it as a supported version. This makes the package break when someone uses yarn.

@jeff3yan
Copy link
Collaborator

Could you also add Node 14 to the .travis.yml configuration? Then the CI can test against v14 for future builds.

@coveralls
Copy link
Collaborator

coveralls commented Dec 15, 2020

Coverage Status

Coverage remained the same at 99.786% when pulling affbf91 on Proscia:master into cbc5738 on tandg-digital:master.

@vpillinger
Copy link
Contributor Author

Could you also add Node 14 to the .travis.yml configuration? Then the CI can test against v14 for future builds.

Done for you. Thanks!

@jeff3yan jeff3yan merged commit 91fb55c into tandg-digital:master Dec 21, 2020
@vpillinger
Copy link
Contributor Author

vpillinger commented Jan 11, 2021

@jeff3yan Is it possible to release a new version to NPM so that we can start using this in Node 14?

@jeff3yan
Copy link
Collaborator

@vpillinger I've pushed the change to NPM now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants