Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional trx and options initializers #54

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

hroland
Copy link
Contributor

@hroland hroland commented Apr 3, 2022

Noticed that in our TS project, we were required to initialize buildFilter with all three of its arguments

Screen Shot 2022-04-03 at 4 25 11 PM

as buildFilter(Model, undefined, undefined), instead of just buildFilter(Model), like in the docs example

PR tested by running tsc --noEmit

@jeff3yan
Copy link
Collaborator

jeff3yan commented Apr 4, 2022

This looks good, thanks for pointing that out.

@jeff3yan jeff3yan merged commit 64d5512 into tandg-digital:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants