Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default evalScripts prop to match documentation. #57

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Changed default evalScripts prop to match documentation. #57

merged 1 commit into from
Apr 21, 2018
+1 −1

Conversation

ronperris
Copy link
Contributor

Motivation

The documentation mentions that the default value for evalScripts is never. The code actually sets the value to once. The evalScripts prop allows scripts to run, this could lead to XSS exploits.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 183

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.0%
Totals Coverage Status
Change from base Build 181: 0.0%
Covered Lines: 19
Relevant Lines: 19
💛 - Coveralls

@tanem
Copy link
Owner

tanem commented Apr 21, 2018 •
edited
Loading

Nice catch, thanks @ronperris. Published in 2.2.18.

@tanem tanem merged commit fd0b740 into tanem:master Apr 21, 2018
tanem pushed a commit that referenced this pull request Aug 6, 2018
Merge pull request #57 from ronperris/master
ed9d200 
Changed default evalScripts prop to match documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronperris @coveralls @tanem