Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Concurrent iOS/tvOS executions free the same address multiple times #494

Closed
tanersener opened this issue Jul 20, 2020 · 2 comments
Closed

Concurrent iOS/tvOS executions free the same address multiple times #494

tanersener opened this issue Jul 20, 2020 · 2 comments
Assignees
@tanersener
Labels
bug Something isn't working enhancement New feature or request fixed

Comments

@tanersener
Copy link
Owner

When multiple executions are started concurrently, AddressSanitizer stops the application with Deallocation of freed memory error. It happens rarely. The reason is pretty obvious, lastCommandOutput is implemented as NSMutableString which is not thread safe.

editor

editor

https://ghostbin.co/paste/q9yoh

Environment

  • Platform: iOS
  • Architecture: x86_64
  • Version: v4.3.2
  • Xcode version: 11.6
  • Cocoapods version: 1.9.2
@tanersener tanersener added the enhancement New feature or request label Jul 20, 2020
@tanersener tanersener self-assigned this Jul 20, 2020
@tanersener tanersener added the bug Something isn't working label Jul 20, 2020
@tanersener tanersener changed the title Concurrent iOS/tvOS executions free the same the address multiple times Concurrent iOS/tvOS executions free the same address multiple times Jul 20, 2020
tanersener added a commit that referenced this issue Jul 21, 2020
@tanersener
synchronize updating lastCommandOutput on ios/tvos, fixes #494
704ee05
@tanersener
Copy link
Owner Author

Fixed in the development branch.

@tanersener
Copy link
Owner Author

Released in v4.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tanersener tanersener

Labels
bug Something isn't working enhancement New feature or request fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tanersener