Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script): add support for 'mavenId()' in 'class' #1155

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

tangcent
Copy link
Owner

@tangcent tangcent commented Aug 11, 2024

implement: #1153
example:

method.doc=groovy:```
"maven:\n```xml\n"+ it.containingClass().mavenId().maven() + "\n```"
```

@tangcent tangcent added the type: new feature Add New Feature label Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.756%. Comparing base (5fddde4) to head (444d24b).

Files Patch % Lines
...ain/kotlin/com/itangcent/idea/utils/MavenHelper.kt 94.828% 1 Missing and 2 partials ⚠️
...com/itangcent/idea/plugin/rule/ScriptRuleParser.kt 60.000% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #1155       +/-   ##
===============================================
+ Coverage     62.625%   62.756%   +0.131%     
- Complexity      2367      2374        +7     
===============================================
  Files            254       255        +1     
  Lines          12265     12335       +70     
  Branches        3016      3030       +14     
===============================================
+ Hits            7681      7741       +60     
- Misses          3003      3009        +6     
- Partials        1581      1585        +4     
Flag Coverage Δ
unittests 62.756% <92.063%> (+0.131%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...com/itangcent/idea/plugin/rule/ScriptRuleParser.kt 52.927% <60.000%> (+0.084%) ⬆️
...ain/kotlin/com/itangcent/idea/utils/MavenHelper.kt 94.828% <94.828%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fddde4...444d24b. Read the comment docs.

@tangcent tangcent force-pushed the feature/script branch 4 times, most recently from 6f431a4 to d98436c Compare August 12, 2024 01:08
@tangcent tangcent merged commit 5ae0736 into master Aug 13, 2024
10 checks passed
@tangcent tangcent deleted the feature/script branch August 13, 2024 00:50
@tangcent tangcent mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new feature Add New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant