Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AND-9589 P2SH support for BCH addresses #870

Merged
merged 1 commit into from
Jan 13, 2025
Merged

AND-9589 P2SH support for BCH addresses #870

merged 1 commit into from
Jan 13, 2025
+37 −10

Conversation

iMaks99
Copy link
Contributor

@iMaks99 iMaks99 commented Jan 10, 2025

No description provided.

@iMaks99 iMaks99 requested review from dbaturin and a team as code owners January 10, 2025 13:33
dbaturin
dbaturin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@dbaturin dbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут, конечно, можно было бы на сам байт опираться, из него буква и выходит. Но и так норм, класс CashAddr кривой, конечно.

@iMaks99 iMaks99 merged commit 43d20a4 into develop Jan 13, 2025
3 checks passed
@iMaks99 iMaks99 deleted the feature/AND-9589-P2SH-support-for-BCH-addresses branch January 13, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaturin dbaturin dbaturin approved these changes

@MasterBin MasterBin MasterBin approved these changes

@nzeeei nzeeei nzeeei approved these changes

@iiiburnyiii iiiburnyiii Awaiting requested review from iiiburnyiii iiiburnyiii is a code owner automatically assigned from tangem/android-reviewers-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iMaks99 @nzeeei @MasterBin @dbaturin