Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-8184: Use GitHub runners for tests #4009

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

m3g0byt3
Copy link
Contributor

@m3g0byt3 m3g0byt3 commented Oct 4, 2024

Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
@m3g0byt3 m3g0byt3 added the WIP Work in progress label Oct 4, 2024
@m3g0byt3 m3g0byt3 requested review from tureck1y and a team as code owners October 4, 2024 11:21
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
@@ -0,0 +1 @@
15.4.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m3g0byt3 m3g0byt3 marked this pull request as draft October 4, 2024 14:09
Comment on lines +20 to +21
ENV["FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT"] = "120"
ENV["FASTLANE_XCODEBUILD_SETTINGS_RETRIES"] = "4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Периодически стреляет, лишним не будет

@@ -7,18 +7,27 @@ ALPHA_SCHEME = "Tangem Alpha"
FIREBASE_TESTERS_GROUP = "testers"

before_all do |lane, options|
xcode_select("/Applications/Xcode.app")
if options[:xcode_version_override].nil?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я собирался добавить это в задаче по ci/cd, но в принципе ничего не мешает уже сейчас добавить

@@ -7,18 +7,27 @@ ALPHA_SCHEME = "Tangem Alpha"
FIREBASE_TESTERS_GROUP = "testers"

before_all do |lane, options|
xcode_select("/Applications/Xcode.app")
if options[:xcode_version_override].nil?
xcodes() # Will use the Xcode version from the .xcode-version file
Copy link
Contributor Author

@m3g0byt3 m3g0byt3 Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Официальный экшн, не какое-то поделие https://docs.fastlane.tools/actions/xcodes/

Если нужный Xcode и так стоит - то ничего устанавливаться не будет:

[14:09:12]: Running xcodes version 1.5.0
[14:09:12]: $ /opt/homebrew/bin/xcodes install '15.4.0' --update --select
[14:09:12]: ▸ Xcode 15.4.0 is already selected
[14:09:12]: $ /opt/homebrew/bin/xcodes installed '15.4.0'
[14:09:12]: ▸ /Applications/Xcode_15.4.app
[14:09:12]: Setting Xcode version '15.4.0' at '/Applications/Xcode_15.4.app' for all build steps


Еще он будет полезен с учетом вот этого breaking change actions/runner-images#10703 - скоро раннеры будут иметь только одну мажорную версию Xcode, а не набор как сейчас:

16.1 (beta) 16B5014f /Applications/Xcode_16.1_beta_2.app
16.0 16A242d /Applications/Xcode_16.app
15.4 (default) 15F31d /Applications/Xcode_15.4.app
15.3 15E204a /Applications/Xcode_15.3.app
15.2 15C500b /Applications/Xcode_15.2.app
15.1 15C65 /Applications/Xcode_15.1.app
15.0.1 15A507 /Applications/Xcode_15.0.1.app
14.3.1 14E300c /Applications/Xcode_14.3.1.app


В образе для раннера этот экшн уже стоит, на self-hosted раннерре его надо будет поставить и один раз запустить, чтобы он сохранил логин-пароль для скачивания xcode https://github.com/XcodesOrg/xcodes?tab=readme-ov-file#install-xcode-

@m3g0byt3 m3g0byt3 changed the title IOS-8184: Use GitHub runners for tests (WIP) IOS-8184: Use GitHub runners for tests Oct 4, 2024
@m3g0byt3 m3g0byt3 removed the WIP Work in progress label Oct 4, 2024
@m3g0byt3 m3g0byt3 marked this pull request as ready for review October 4, 2024 14:18
@m3g0byt3 m3g0byt3 enabled auto-merge (squash) October 4, 2024 16:26
@m3g0byt3 m3g0byt3 requested review from fedorov-d and removed request for Balashov152 October 7, 2024 09:17
…ests

Signed-off-by: Andrey Fedorov <afedorov@tangem.com>
@m3g0byt3 m3g0byt3 merged commit 7949988 into develop Oct 8, 2024
3 checks passed
@m3g0byt3 m3g0byt3 deleted the feature/IOS-8184_use_github_runners_for_tests branch October 8, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants