IOS-8202 Send: Recent list isn't displayed for tokens. #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3g0byt3
reviewed
Oct 11, 2024
| else { | ||
| return nil | ||
| } | ||
|
|
||
| let address: String | ||
| switch interactionAddress(from: record) { | ||
| case .user(let value), .contract(let value): |
There was a problem hiding this comment.
А остальные типы не должны тут обрабатываться?
Как минимум .multiple кажется весьма распостранен в UTXO сетках
There was a problem hiding this comment.
Договорились после дейлика что не надо
There was a problem hiding this comment.
Рассуждения такие что у нас сейчас нет токенов в UTXO сетях, которые поддерживают историю транзакций, так что даже потестить не получится.
А просто для сетей UTXO (не в токенах) сейчас все ок
tureck1y
previously approved these changes
Oct 14, 2024
amuraveinik
force-pushed
the
bugfix/IOS-8202_recent_for_tokens
branch
from
cb03d5f
to
ec141f6
Compare
amuraveinik
force-pushed
the
bugfix/IOS-8202_recent_for_tokens
branch
from
ec141f6
to
b8e972c
Compare
tureck1y
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOS-8202
Проверялось на адресе 0xE35F09B310479fFdC10Ff583349C1020295AfEcF
Для сравнения, что выводится в приложении и в экплорере
Тут нужно смотреть только OUT, и чтобы справа было USDT