iOS-7766 [Staking] Binance #4088
Open
+251
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… restaking validator
…otification on summary
Balashov152
reviewed
Oct 18, 2024
| @@ -98,7 +98,6 @@ class EthereumTransactionBuilder { | |||
| input.toAddress = destination | |||
|
|
|||
| input.transaction = .with { transaction in | |||
| input.toAddress = destination | |||
There was a problem hiding this comment.
ух, сначала напугался, потом увидел что задублировался код )
| private extension Blockchain { | ||
| var stakeKitNetworkID: String { | ||
| switch self { | ||
| case .bsc: "binance" |
There was a problem hiding this comment.
Опять эти расхождения стремные(
А глянь плиз может networkId заюзать можно, или там не то будет тоже?
Comment on lines
+335
to
+340
| case .pending(let pendingAction): | ||
| switch pendingAction { | ||
| case .restake(let passthrough): | ||
| coordinator?.openRestakingFlow(action: action) | ||
| default: coordinator?.openStakingSingleActionFlow(action: action) | ||
| } |
There was a problem hiding this comment.
Suggested change
| case .pending(let pendingAction): | |
| switch pendingAction { | |
| case .restake(let passthrough): | |
| coordinator?.openRestakingFlow(action: action) | |
| default: coordinator?.openStakingSingleActionFlow(action: action) | |
| } | |
| case .pending(.restake): | |
| coordinator?.openRestakingFlow(action: action) | |
| case .pending: | |
| coordinator?.openStakingSingleActionFlow(action: action) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена поддержка флоу рестейкинга. Также исправлен флоу анстейкинга: в нем была проблема с валидацией вводимой суммы.