Create wallet from the seed #262
Conversation
|
Переименовал все на IsImported / keysImport |
| @@ -44,7 +44,8 @@ class WalletDeserializer { | |||
|
|
|||
| func deserializeWallet(from decoder: TlvDecoder) throws -> Card.Wallet { | |||
| let status: Card.Wallet.Status = try decoder.decode(.status) | |||
| guard status == .loaded || status == .backuped else { //We need only loaded wallets | |||
There was a problem hiding this comment.
loaded надо переименовать на generated видимо. Непонятно вообще. Не читается.
There was a problem hiding this comment.
Типа Imported, Generated
GeneratedAndBackedup
ImportedAndBackedup
There was a problem hiding this comment.
это же внутрянка сдк, не хочется ее делать сильно далеко от документации карты
There was a problem hiding this comment.
Ну пока ок, тогда, на надо и в документации поправить просто.
| @@ -44,7 +44,8 @@ class WalletDeserializer { | |||
|
|
|||
| func deserializeWallet(from decoder: TlvDecoder) throws -> Card.Wallet { | |||
| let status: Card.Wallet.Status = try decoder.decode(.status) | |||
| guard status == .loaded || status == .backuped else { //We need only loaded wallets | |||
|
|
|||
| if !status.isLoaded { //We need only loaded wallets | |||
There was a problem hiding this comment.
Вообще не поймешь, что это значит
There was a problem hiding this comment.
сделал isAvailable
| private let signingMethod = SigningMethod.signHash | ||
|
|
||
| /// Default initializer | ||
| /// - Parameter curve: Elliptic curve of the wallet. `Card.supportedCurves` contains all curves supported by the card | ||
| init(curve: EllipticCurve) { | ||
| /// - Parameter seed: An optional BIP39 seed to create wallet from. COS v6.10+. | ||
| init(curve: EllipticCurve, seed: Data?) throws { |
There was a problem hiding this comment.
А нельзя сделать два конструктора? Мне кажется понятнее будет.
There was a problem hiding this comment.
Имхо так понятнее. Сид есть - будет использоваться, Сида нет - не будет.
| if let seed { | ||
| self.keyToImport = try BIP32().makeMasterKey(from: seed, curve: curve) | ||
| } else { | ||
| self.keyToImport = nil |
There was a problem hiding this comment.
А он изначально не nil?
There was a problem hiding this comment.
нет, это же константа и ее надо проинициализировать явно в конструкторе
TangemSdk/TangemSdk/Operations/Wallet/CreateWalletCommand.swift
Outdated
Show resolved
Hide resolved
TangemSdk/TangemSdk/Operations/Wallet/CreateWalletCommand.swift
Outdated
Show resolved
Hide resolved
| private var derivationTask: DeriveWalletPublicKeysTask? = nil | ||
| /// Default initializer | ||
| /// - Parameter curve: Elliptic curve of the wallet. `Card.supportedCurves` contains all curves supported by the card | ||
| public init(curve: EllipticCurve) { | ||
| /// - Parameter seed: An optional BIP39 seed to create wallet from. COS v6.10+. Nil by default. | ||
| public init(curve: EllipticCurve, seed: Data? = nil) { |
There was a problem hiding this comment.
Опять же, может разные конструкторы? все же хочется разделить на столько разные задачи
|
Обновил код. Ответил там, где по комментам не правил |
No description provided.