ddl: move public hidden columns to a right position #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #110
Problem Summary:
onCreateIndex()
, we can't update the hidden columns state step by step(e.g, fromnone
todelete-only
), because the non-public columns are ignored in the update assignments list construction(buildUpdateList
). As a result,rebuildIndices()
panic because thetouched
array does not contain the index(indelete-only
state) columns. See ddl: fix expression index with insert causes losing index data pingcap/tidb#26248.TableInfo.Cols()
because "Columns[xxx.Offset]" is used everywhere. It is easy to make mistakes.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.