Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and use fixed_array() function. #31

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Add and use fixed_array() function. #31

merged 3 commits into from
Oct 16, 2023

Conversation

tmpfs
Copy link
Contributor

@tmpfs tmpfs commented Oct 16, 2023

To ensure that ChaChaRng is always presented with the correct number of bytes.

Summary of changes
Changes introduced in this pull request:

  • Add the fixed_array() function which does an infallible conversion to N where N is typically 32
  • Use fixed_array() wherever we seed ChaChaRng.

Closes #28

tmpfs added 3 commits October 16, 2023 08:55
@tmpfs
Add and use fixed_array() function.
c5ab745 
To ensure that ChaChaRng is always presented with the correct number of
bytes.
@tmpfs
Formatting.
98b50e0
@tmpfs
Fix clippy warnings.
b8e3f68
drewstone
drewstone approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewstone drewstone merged commit c72f22d into main Oct 16, 2023
4 of 5 checks passed
@drewstone drewstone deleted the fixed-array branch October 16, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix flaky tests
2 participants
@tmpfs @drewstone