feat(blueprint-metadata): nicer errors #621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only adds error messages for some cases. Many others are still just panics.
This also fixes the issue of missing metadata producing an empty
BlueprintMetadata
and allowing the crate to continue building. It's now a hard error.Removing the metadata from
incredible-squaring
yields:Notice the new cargo warning message up top and the log levels in stderr. Still isn't that pretty, but it's the best that can be done AFAIK.