Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump curve25519-dalek to latest #478

Closed
wants to merge 4 commits into from
Closed

Conversation

salman01zp
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Bump curve25519-dalek from v4.1.1 to v4.1.2

Reference issue to close (if applicable)

Closes

@salman01zp
Copy link
Contributor Author

salman01zp commented Feb 17, 2024

Bump curve25519-dale here which included path fix w3f/schnorrkel#101

@drewstone
Copy link
Contributor

Did you fix not work @salman01zp ?

@salman01zp
Copy link
Contributor Author

All dependencies that use curve25519-dalek need to be bumped to v4.1.2.
The following are dependencies that need to be updated.

libp2p-noise 0.42.2 -->. x25519-dalek 1.1.1 --> "curve25519-dalek 3.2.0"
sp-core 21.0.0 --> schnorrkel: 0.9.1-->"curve25519-dalek 2.1.3",

Solution

All this to fix the Clippy Issue. What a mess

@drewstone
Copy link
Contributor

We need to update to 1.7.0

@drewstone
Copy link
Contributor

Closing in favor of #498

@drewstone drewstone closed this Feb 28, 2024
@shekohex shekohex deleted the salman/bump-curve25519-dalek branch August 6, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants