-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tangle subxt #505
Tangle subxt #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole thing can be replaced by
subxt metadata -f bytes --url wss://testnet-rpc.tangle.tools > metadata.scale
subxt codegen --file metadata.scale > ./tangle_runtime.rs
Also should we even store this in the repo? Which version of runtime does this represent? the testnet/mainnet/main-branch? imo any project can run the above two lines and generate the interface, we dont need this at all.
We use tangle runtime-interface for relayer and pallet-eth2-light-client as of now.
So the idea was to generate tangle runtime-interface after each tangle release, which can be used by other crates just like what we do with Typescript types. Eventually, use CI to generate this on the new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would say let's go one more step further and add the CI that will compile tangle, and update the metadata+codegen, then push to the repo the updated code as a PR.
Still dont understand the value of all this code, if tangle.metadata and tangle_runtime.rs is the files we want, we can get it by running two lines I mentioned above. We can keep those files in the repo, but the build logic looks useless to me |
Ah, I see what you mean. Yes we can get rid of the build.rs, I just moved it from webb-rs. |
* Update to 1.7.0 * Bump curve25519-dalek * frontier update changes * update local path * fix issue with evm crates * compile roles pallet * update mock configurations * remove light client from tangle * update schnorrkel to 0.11.4 * update testnet configuration * compiles testnet-runtime * compile mainnet runtime * compiles and build tangle * Tangle subxt (#505) * tangle subxt * use curve25519-dalek 4.1.1 to match lit-frost requirement * cargo fmt * enable stdsimd feature * enable simd feature * removd simd feature * regenerate cargo.lock * remove cache from CI * revert rust-toolchain * cargo update * cargo fmt * Update tangle-subxt * Fmt, update * Clippy fix * Fmt * use stable rust * cargo fmt * update CI job * clippy fix + fix democracy precompile tests * fix tx-pause tests * update sha2256sum statement link * fmt --------- Co-authored-by: salman01zp <pathansalman555@gmail.com> Co-authored-by: Shady Khalifa <dev+github@shadykhalifa.me>
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes