Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rewards pallet #867

Merged
merged 69 commits into from
Jan 8, 2025
Merged

feat: Rewards pallet #867

merged 69 commits into from
Jan 8, 2025

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Jan 2, 2025

Summary of changes
Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

1xstj added 30 commits December 10, 2024 19:48
@1xstj
Merge branch 'main' of github.com:tangle-network/tangle into feat/evm…
3f7dd29 
…-restaking
@1xstj
chore : switch to asset-id evm
b7644b8
@1xstj
cleanup
ce7effe
@1xstj
bump subxt
cf47bec
@1xstj
clean slate
663f374
@1xstj
Merge branch 'main' of github.com:tangle-network/tangle into feat/evm…
f65f735 
…-restaking
@1xstj
use common exports
5a677c8
@1xstj
use common exports
5e53247
@1xstj
wip
87181bb
@1xstj
wip
fadb9f6
@1xstj
wip
4d6b596
@1xstj
fix compile
c214aca
@1xstj
cleanup
a704da2
@1xstj
compiling
6b51c97
@1xstj
precompiles fixes
4cc8780
@1xstj
Merge branch 'main' of github.com:tangle-network/tangle into feat/evm…
b1719ee 
…-restaking
@1xstj
runtimes building
4a2a2a8
@1xstj
update mocks
35f9394
@1xstj
cleanup tests
42a56fe
@1xstj
update js types
145ff94
@1xstj
update subxt
0c400ac
@1xstj
cleanup clippy
c179e4c
@1xstj
use nightly fmt
8c58a05
@1xstj
use stable fmt
130955c
@1xstj
cleanup clippy
59b2375
@1xstj
cleanup tests
f59c794
@1xstj
cleanup tests
0e72e74
@1xstj
cleanup fmt
ec34241
@1xstj
more tests passing
99c6b08
@1xstj
cleanup clippy
eeb5487
@1xstj 1xstj added the wip 🚧 label Jan 2, 2025
drewstone
drewstone requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see negative tests, tests of failing to deposit over caps, tests of failing with respect to lock multiplier (are there failing cases)?

precompiles/rewards/Rewards.sol Outdated Show resolved Hide resolved
@1xstj 1xstj marked this pull request as ready for review January 7, 2025 11:04
@1xstj 1xstj requested a review from shekohex as a code owner January 7, 2025 11:04
@1xstj 1xstj removed the wip 🚧 label Jan 7, 2025
@drewstone drewstone merged commit 0b826fc into main Jan 8, 2025
4 checks passed
@drewstone drewstone deleted the rewards-pallet branch January 8, 2025 05:08
@1xstj 1xstj mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex requested changes

@drewstone drewstone drewstone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1xstj @drewstone @shekohex