Android add TLS 1.2 for pre-lollipop

[hjanetzek]

Same is needed for Pelias and Valhalla android clients. Also there seem to be Android 7.0 devices which lack to enable TLS 1.2 ..

http://stackoverflow.com/questions/39133437/sslhandshakeexception-handshake-failed-on-android-n-7-0
https://issuetracker.google.com/issues/37122132

[tallytalwar]

cc. @sarahlensing, @msmollin for pelias and valhalla work.

[msmollin]

I am not following the correlation between this code change, enabling TLS 1.2 on 4.x devices, and the links which talk about Android 7.0 missing valid cipher suites for TLS 1.2. Does this change somehow alleviate that problem?

[hjanetzek]

@msmollin the pre-lollipop related links was
square/okhttp#2372 (comment)
mapzen/android#360 (comment)

The solution for some Android 7.0 devices adds also the cipher suite to the snippet above. Not sure how to handle this case - I've just added the comment for further investigation :)

ConnectionSpec spec = new ConnectionSpec.Builder(ConnectionSpec.MODERN_TLS)
            .tlsVersions(TlsVersion.TLS_1_2)
            .cipherSuites(CipherSuite.TLS_DHE_RSA_WITH_AES_256_CBC_SHA)
            .build();

from http://stackoverflow.com/a/41874704

[matteblair]

Confirmed on a tablet running 4.2.2 that SSL is broken before this fix and works after this fix.

[sarahsnow1]

@tallytalwar thanks for the heads up, relevant pelias and valhalla tickets created here:
pelias/pelias-android-sdk#75
mapzen/on-the-road_android#115