Fix label collider tile scale #2142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjanetzek or @karimnaaji would remember the code here the most. But I can give it a try. Thanks @rwrx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was testing tile fallbacking feature I discovered that when tile fallback (there is a pull request for tile fallback here: #2120) is from zoom 16 to zoom 0 there just occurred an int 32 overflow in allocation https://github.com/tangrams/isect2d/blob/2e1a75cee09d9949900e926c61c86505b09205b2/include/isect2d.h#L60 . So while trying it and profiling memory usage on Android device I came out with a solution to not process labels when tile scale difference is larger or equal to 6 so it won't much consume RAM and also it won't crash on bad alloc exception. I am not sure if this proposed solution is a right one.