Re-add direct setter and getter for camera type

[matteblair]

We had this feature before, and removed it in favor of using a "scene update" to change the camera type. While technically sufficient and correct, the "scene update" approach is much more cumbersome than a direct setter! Of course we can't add direct setters for every part of the scene, but since we provide direct control over every other aspect of the view (zoom, position, tilt, etc.) it seems reasonable that the camera type should be just as easy to access and modify.

[tallytalwar]

I agree.

The only concern I have is out of all the view calls we allow (zoom, position, tilt, cameraType change) this is the only one dependent on the scene file. If the scene file does not specify these camera types what should be the behavior?

[matteblair]

The camera element in the scene file has parameters for position and zoom as well, so this doesn't seem that different. Can you clarify what you mean?

[tallytalwar]

perspective and isometric camera types use different configurations specified in the scene file.
If one does not provide these configuration in the scene file and change the camera type, it will result in bad camera/renders.

Example if one only has isometric camera set in the scene file with apt parameter ('axis') set.. and then camera type is changed from isometric to perspective (with no information of perspective camera parameters (fov, focal_length, etc) available).

[matteblair]

All of these parameters have documented default values, so I don't think
one could produce an "invalid" configuration.
On Jun 15, 2016 12:27 PM, "Varun" notifications@github.com wrote:

perspective and isometric camera types use different configurations
specified in the scene file.
If one does not provide these configuration in the scene file and change
the camera type, it will result in bad camera/renders.

Example if one only has isometric camera set in the scene file with apt
parameter ('axis') set.. and then camera type is changed from isometric
to perspective (with no information of perspective camera parameters (fov,
focal_length, etc) available).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#793 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADNzSjXkcZW43a9w9mb5Hg4tlazJeMTpks5qMCfVgaJpZM4I2hed
.

[tallytalwar]

Note: Update documentation when this gets released with our next release.