Merge projection view module #9
Conversation
tallytalwar
commented
Sep 22, 2014
tallytalwar
commented
- view module contains an instance of projection now.
- needed for further support for multiple map projection support in future.
…t to mercator projection, unless some other projection is specified.
|
|
||
| ViewModule::ViewModule(float _width, float _height) { | ||
| ViewModule::ViewModule(float _width, float _height, ProjectionType _projType) { | ||
| setMapProjection(_projType); |
There was a problem hiding this comment.
Where possible, I think we should consolidate functionality such that code is minimally repeated. For instance, add a projection argument to init() and call setMapProjection within init(). Needing to update code in multiple locations leads to a lot of problems in my experience.
|
cc @iwillig - check this out and add any comments! |
|
@rmarianski, you might also have some feedback on this. |
| @@ -109,7 +109,7 @@ class MercProjection : public MapProjection { | |||
| * _type: type of map projection, example ProjectionType::Mercator | |||
| * _tileSize: size of the map tile, default is 256 | |||
| */ | |||
| MercProjection(ProjectionType _type, int _tileSize=256); | |||
| MercProjection(int _tileSize=256); | |||
There was a problem hiding this comment.
Left tileSize in there for the time being.. if we are not using any mercator pixel conversion method then we can get rid of this.
There was a problem hiding this comment.
You need some unit to measure tiles so you can do things like calculate how many tiles wide/high the viewport should be for a given zoom level in standard web mercator view. It doesn't have to be "pixels", but it's as good as anything else (and the long-time standard, so I think it's clearer than using something else). With retina/high-density displaces, it's more an abstract unit now than an actual pixel, but that's a problem across all app/web development these days anyway, so not unique here...
|
I read through the diff and nothing big jumped out at me. I just had a couple of comments here and there about some pieces. 👍 |
