Add context / implicit params to synthetics #2

tanishiking · 2021-08-02T07:05:57Z

This PR adds synthetics (for implicit-param and context-param application) to SemanticDB.

Questions

Should we add a compiler option to control whether the compiler should emit synthetics information or not
- which is available in Scala2 https://scalameta.org/docs/semanticdb/guide.html#scalac-compiler-plugin and default to off
- -P:semanticdb:synthetics:<value> in Scala2

Added synthetics

implicit / context params application

def foo(x: Int)(using Int) = ???
def m(using x: Int) = foo(0)

// synthetics
def m(using x: Int) = foo(0)<<(x)>>

Synthetic(
  <foo(0)>,
  ApplyTree(
    OriginalTree(<foo(0)>),
    List(
      IdTree(<x>),
    )
  )
)

Same with Implicit parameters synthetics in Scala2 https://scalameta.org/docs/semanticdb/specification.html#synthetic-1

anonymous context params

def foo(using Int) = ???
 
// synthetic
def foo(using x$1: Int) = ???

Synthetic(
  <Int>,
  IdTree(<x$1>)
)

(Maybe range should be between using and Int, instead of overlaps with Int).

anonymous given value

given Int = 1

// synthetic
given given_Int: Int = 1

Synthetic(
  <given Int = 1>,
  IdTree(<given_Int>)
)

scala#12885 (comment)

To construct symbol table before referring the ParamRef it's required to traverse the child trees before registering the symbol.

Previously, there were the risks that localIdx receives the symbol that doens't have `span` because `TypeOps` generates dummy symbols for refinements in `RefinedType` and `RecType`. However, with the following commits, scala@7dd91ad scala@226e26f now we never generate dummy symbol in `TypeOps`. So re-insert the assertion we deleted when copying this method from `ExtractSemanticDB`. see: https://github.com/lampepfl/dotty/pull/12885/files#r658150249

For wildcard type `C[_ <: T]`, it's internal type representation will be `AppliedType(TypeBounds(lo = <Nothing>, hi = <T>))`. As scalameta for Scala2 does, we'll convert the wildcard type to `ExistentialType(TypeRef(NoPrefix, C, <local0>), Scope(hardlinks = List(<local0>)))` where `<local0>` has - display_name: "_" and, - signature: type_signature(..., lo = <Nothing>, hi = <T>) See: https://github.com/lampepfl/dotty/pull/12885/files#r663797616 https://scalameta.org/docs/semanticdb/specification.html#type-2 Now, when we compile the following Scala program to semanticdb ```scala class Wildcards { def e1: List[_ <: Int] = ??? } ``` The semanticdb's SymbolInformation for `e1` looks like: From scala3 ``` symbols { symbol: "advanced/Wildcards#e1()." kind: METHOD display_name: "e1" language: SCALA signature { value_signature { tpe { by_name_type { tpe { existential_type { tpe { type_ref { symbol: "scala/collection/immutable/List#" type_arguments { type_ref { symbol: "local0" } } } } declarations { hardlinks { symbol: "local0" kind: TYPE display_name: "_" language: SCALA signature { type_signature { type_parameters { } lower_bound { type_ref { symbol: "scala/Nothing#" } } upper_bound { type_ref { symbol: "scala/Int#" } } } } } } } } } } } } } ``` On the other hand, generated from scalameta's metac with scalac 2.13.6 ```sh $ metac --version Scala compiler version 2.13.6 -- Copyright 2002-2021, LAMP/EPFL and Lightbend, Inc. ``` ``` symbols { symbol: "advanced/Wildcards#e()." kind: METHOD display_name: "e" language: SCALA signature { method_signature { type_parameters { } return_type { existential_type { tpe { type_ref { symbol: "scala/package.List#" type_arguments { type_ref { symbol: "local0" } } } } declarations { hardlinks { symbol: "local0" kind: TYPE properties: 4 display_name: "_" language: SCALA signature { type_signature { type_parameters { } lower_bound { type_ref { symbol: "scala/Nothing#" } } upper_bound { type_ref { symbol: "scala/Int#" } } } } access { public_access { } } } } } } } } access { public_access { } } } ```

For example: `def foo(x: T)(y: T): T` and for `<y>.owner.info` would be like `MethodType(...<x>, resType = MethodType(...<y>, resType = <T>))`. (Let's say the outer `MethodType` "outer", and `MethodType` who is `resType` of outer "inner") Before this commit, we register <y> to the symbol table with `(<y>, outer)`, which should be `(<y>, inner)`. For such a nested method signature, we have to find the "actual" binder for parameters and register them to the symbol table.

When the prefix of SingleType is Type.Emtpy, we had been printing them as `<?>.sym.type`, but it should be `sym.type`

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>

…thod

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>

Because there could be an unexpected types for incompilable sources and if we show the warning for uncompilable sources, it could be confusing.

see: scala#12885 (comment) scala#12885 (comment)

and added anonymous context param to synthetics

PR comments #2

Update docs canthrow.md remove bad type alias at line 70

tanishiking and others added 30 commits June 24, 2021 14:02

Add Singature information for Semanticdb

2847a1c

Reset local symbol index for each TextDocument, updateExpect

d21fe59

PrettyPrint signature and update metac.expect

9c6015e

Integrate SymbolInformationOps into Scala3#SymbolOps

90177c6

Model WithType for AndType

de36d34

scala#12885 (comment)

Resolve ParamRef by constructing SymbolTable

7dd91ad

To construct symbol table before referring the ParamRef it's required to traverse the child trees before registering the symbol.

Lookup symbols for refinements in RefinedType and RecType

226e26f

Convert AndType to IntersectionType

0325a22

Refactor enterRefined

3cad5f3

Refactor: move all extension (of Symbol) method into Scala3

a3e1f53

Don't add type parameters as parameters to MethodSignature

75bc739

Refactor not to use isInstanceOf for designator of TypeRef and TermRef

fa167bc

Use intersection type for the parent of RefinedType

5af0737

Use finalResultType for MethodSignature to get actual return type.

139491b

Remove unused parameter sym from toSemanticType

5b0a549

Fix pprint issue for SingleType

5359f22

When the prefix of SingleType is Type.Emtpy, we had been printing them as `<?>.sym.type`, but it should be `sym.type`

Convert symbols to local index for funParamSymbol

9a0d3ac

Merge branch 'master' into semanticdb-signature

a524093

Refactor style of if

2d54bb7

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>

Fix printing upper type bounds

a26f501

Add evidence params to SemanticDB

907a386

Add refinements to RefinedType generated by opaque types

08d2382

Fix empty refinement for RefinedType for the result of polymorphic me…

e68287a

…thod

Print definition of ExistentialType instead of displaySymbol

1622980

Update comment

6e3ff06

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>

None for empty decls

82a5043

Warn if symbol lookup failed for paramRef and RefinedType

09e62eb

tanishiking added 18 commits July 14, 2021 16:14

Warn if unexpected type appear while converting type to SemanticDB type

2b651c3

Dealias LazyRef while converting types to SemanticDB

a1e0f7f

Do not emit warning for unexpected type

b606c41

Because there could be an unexpected types for incompilable sources and if we show the warning for uncompilable sources, it could be confusing.

Do not create a newSymbol for ParamRef

3496704

Make wildcard type symbol global

95af95c

Hardlink fake symbols

4925091

Excude symbols that doesn't present in source from occurrence

fd3b71c

Merge branch 'master' into semanticdb-signature

41c118e

Make namePresenInSource safe for IndexOutOfRange

c0e7b88

Make package objects present in source

4f60d9f

Fallback to fake symbol for refinements in RefinedType of upper bound

6529e8f

see: scala#12885 (comment) scala#12885 (comment)

Add occurrences of secondary constructors

ba8140f

Add fakeSymbols to symbol section and don't hardlink fake syms

8e7e764

Convert tp <:< FromJavaObject to tp <:< Any

fed18ec

Do not add wildcard symbol of existential type to symbol section

114d4c2

Add implicit or context param apply to synthetics

aed91ad

and added anonymous context param to synthetics

Convert TypeVar to stripped type

08f7f09

Add invented given to synthetics

264c184

This was referenced Aug 2, 2021

Add Synthetics section to SemanticDB scala/scala3#13135

Open

False positive unused warning for implicit/context params and implicit conversion tanishiking/scalafix-unused#2

Open

tanishiking pushed a commit that referenced this pull request Aug 9, 2021

Split FrontEnd into Parser and TyperPhase

c4e5303

PR comments #2

tanishiking force-pushed the semanticdb-signature branch from 04464b9 to 861d3a4 Compare August 10, 2021 18:19

tanishiking pushed a commit that referenced this pull request Aug 10, 2021

Split FrontEnd into Parser and TyperPhase

5e0ae1f

PR comments #2

tanishiking force-pushed the semanticdb-signature branch 2 times, most recently from f51da32 to 056f4a4 Compare August 10, 2021 19:09

Merge branch 'semanticdb-signature' into synthetics-context-params

ec7da57

tanishiking mentioned this pull request Aug 11, 2021

Add context / implicit params to synthetics scala/scala3#13279

Closed

tanishiking closed this Aug 11, 2021

tanishiking deleted the synthetics-context-params branch August 11, 2021 06:39

tanishiking pushed a commit that referenced this pull request Sep 21, 2023

Merge pull request #2 from bjornregnell/bjornregnell-patch-1

207b188

Update docs canthrow.md remove bad type alias at line 70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add context / implicit params to synthetics #2

Add context / implicit params to synthetics #2

tanishiking commented Aug 2, 2021 •

edited

Loading

Add context / implicit params to synthetics #2

Add context / implicit params to synthetics #2

Conversation

tanishiking commented Aug 2, 2021 • edited Loading

Questions

Added synthetics

implicit / context params application

anonymous context params

anonymous given value

tanishiking commented Aug 2, 2021 •

edited

Loading