Add jenkins2 build scripts. #2
Conversation
Gruntfile.js
Outdated
| cmd: function (target) { | ||
| var cmd; | ||
| if (process.platform === 'win32') { | ||
| cmd = 'cd windows\\vs2015 && msbuild yara.sln /t:Rebuild /p:Configuration=Release' |
There was a problem hiding this comment.
you prob need to make a distinction between target === 'win32' and target === 'win64' and change the windows build command accordingly
I think its /property:Platform=x64 and /property:Platform=x86 but you'd have to verify in the solution
| description: 'Tanium fork of YARA' | ||
| }; | ||
|
|
||
| var versionPrefix = '3.4.0'; |
There was a problem hiding this comment.
change to var versionPrefix = '3.4.0-'; with a trailing -
see package.json https://jenkins.corp.tanium.com/job/Tanium/job/yara/job/feature%252Fjenkins2/1/artifact/centos5_linux64/package.json/*view*/
Gruntfile.js
Outdated
| } else { | ||
| cmd = './build.sh' | ||
| } | ||
| grunt.log.ok(cmd); |
There was a problem hiding this comment.
where does the build output go? need to copy that into ./build so it gets archived and eventually published to artifactory
| // default to win64 on windows | ||
| return 'win64'; | ||
| } else if (process.platform === 'linux') { | ||
| if (process.platform === 'x64') { |
There was a problem hiding this comment.
@bwknight877 looks like we might have confused process.platform and process.arch here.
There was a problem hiding this comment.
yeah, i fixed that in common-libuv and common-yaml just now
Add jenkins2 build scripts.
@bwknight877 I mostly copied the scripts from the tanium-libuv branch you showed me but I think I'm missing a few differences here. Let's review together when you get a chance today.